Skip to content

Conversation

@deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#296

Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#296
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

代码审查意见:

  1. .syncexclude文件中新增的CHANGELOG.md是否确实不应该被同步,需要确认这一变更的意图。
  2. xcb/linux.cmake文件中,新增了对Qt6Xcb_INCLUDE_DIR的设置和检查,这可能是为了支持Qt6版本。但是,Qt6Xcb_INCLUDE_DIR的设置方式可能不正确,因为list(GET Qt6Core_INCLUDE_DIRS 0 dir)只是获取了Qt6Core_INCLUDE_DIRS列表的第一个元素,而不是Qt6Core的完整路径。建议检查Qt6Core_INCLUDE_DIRS是否包含Qt6Xcb的路径。
  3. Qt6Xcb_INCLUDE_DIR的设置中,使用了string(REPLACE "QtCore" "QtXcb" Qt6Xcb_INCLUDE_DIR ${dir}),这可能会导致路径错误,因为QtCore可能不是Qt6Core_INCLUDE_DIRS列表中的最后一个元素。建议使用更可靠的方法来构建Qt6Xcb_INCLUDE_DIR
  4. if(EXISTS ${Qt6Xcb_INCLUDE_DIR}/${Qt6_VERSION}/QtXcb/private)条件判断中,如果路径构建正确,那么这一行代码是合理的。但是,如果路径构建不正确,可能会导致错误。建议在路径构建之前添加日志输出,以便于调试。
  5. include_directories(${CMAKE_CURRENT_LIST_DIR}/libqt6xcbqpa-dev/${Qt6_VERSION})include_directories(${Qt6Xcb_INCLUDE_DIR}/${Qt6_VERSION}/QtXcb/private)中,如果路径构建正确,那么这两行代码是合理的。但是,如果路径构建不正确,可能会导致错误。建议在路径构建之前添加日志输出,以便于调试。
  6. message(FATAL_ERROR "Not support Qt Version: ${Qt6_VERSION}")中,如果路径构建不正确,那么这一行代码是合理的。但是,如果路径构建正确,那么这一行代码可能是多余的。建议在路径构建正确时删除这一行代码。

总的来说,这些代码变更可能需要进一步的测试和验证,以确保它们能够正确地工作。同时,建议添加更多的日志输出,以便于调试和问题追踪。

@18202781743 18202781743 merged commit 915c618 into master Jul 8, 2025
29 of 31 checks passed
@18202781743 18202781743 deleted the sync-pr-296-nosync branch July 8, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants